chore: use GitHub App token for releases#888
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b048541 in 10 seconds. Click for details.
- Reviewed
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_lZ7gDjW5M0z7BwgD
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
📝 WalkthroughWalkthroughRelease workflow now generates a GitHub App token via Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Maintainer
participant Release_Workflow as "Release Workflow"
participant Create_Token as "actions/create-github-app-token"
participant GitHub_App as "GitHub App"
participant Actions as "Actions (checkout/version/release)"
participant Repo as "Repository API"
Maintainer->>Release_Workflow: trigger release workflow
Release_Workflow->>Create_Token: run with app-id & private-key
Create_Token->>GitHub_App: request app installation token
GitHub_App-->>Create_Token: return token
Create_Token-->>Release_Workflow: outputs.token
Release_Workflow->>Actions: checkout using token (x-access-token)
Actions->>Repo: perform version bump / create release / publish changelog with token
Repo-->>Actions: respond success
Actions-->>Release_Workflow: steps complete
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/release.yml:
- Around line 9-11: The permissions block currently grants the default
GITHUB_TOKEN unnecessary repo write access via "contents: write"; remove the
"contents: write" entry from the permissions map in
.github/workflows/release.yml (leave "id-token: write" intact) so the workflow
follows least-privilege and all write actions continue to use the app token
instead of GITHUB_TOKEN.
b048541 to
f636a45
Compare
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed f636a45 in 8 seconds. Click for details.
- Reviewed
46lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_vckTv8ckr3o2hgdX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 0d40157 in 6 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_rt5M0gPz1iUpcFw0
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
50-56:⚠️ Potential issue | 🟡 MinorUpdate
softprops/action-gh-releasefrom v1 to v2.The action is pinned to v1, which is outdated. The latest version is v2.5.0 with the major version available as
@v2. Upgrade to benefit from bug fixes, improvements, and ongoing maintenance.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
37-43: Consider using local git config instead of global.While the runner is ephemeral, using
--local(or omitting the flag, which defaults to local) is a better practice for CI environments. It ensures configuration is scoped to the repository and avoids potential issues with parallel jobs.♻️ Suggested change
- name: Git Identity run: | - git config --global user.name 'github-actions[bot]' - git config --global user.email 'github-actions[bot]@users.noreply.github.com' + git config user.name 'github-actions[bot]' + git config user.email 'github-actions[bot]@users.noreply.github.com' git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/$GITHUB_REPOSITORY env: GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
Replace GH_ACCESS_TOKEN with GitHub App token for better security and to avoid rate limiting issues.
Changes:
Required secrets:
Important
Replaces
GH_ACCESS_TOKENwith a GitHub App token in the release workflow for improved security and reliability.GH_ACCESS_TOKENwith a GitHub App token for authentication in.github/workflows/release.yml.actions/create-github-app-token@v2.actions/checkout@v4to use the app token.CI_BOT_APP_IDandCI_BOT_PRIVATE_KEYsecrets for token generation.This description was created by
for 0d40157. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit