shell: use binfmt misc instead of ld preload to detect wasm executable#226
Closed
btheado wants to merge 4 commits intotractordev:mainfrom
Closed
shell: use binfmt misc instead of ld preload to detect wasm executable#226btheado wants to merge 4 commits intotractordev:mainfrom
btheado wants to merge 4 commits intotractordev:mainfrom
Conversation
btheado
commented
Nov 15, 2025
| COPY --from=lib32 /lib/ld-linux.so.2 /rootfs/lib/ | ||
| COPY --from=lib32 /lib/i386-linux-gnu/libc.so.6 /rootfs/lib/ | ||
| COPY --from=lib32 /lib/i386-linux-gnu/libm.so.6 /rootfs/lib/ | ||
| COPY --from=lib32 /lib/i386-linux-gnu/libresolv.so.2 /rootfs/lib/ |
Author
There was a problem hiding this comment.
I wasn't able to determine if all these .so files are only for busybox. Especially this one. What tests should I run for this change?
Contributor
|
Hugely glad you took the time to take this on an make a PR, but major changes have made this obsoleted. We use binfmt_misc in Apptron and the eventual alpine bundle, but our built-in shell is going back to a single binary so we dont need to depend on a VM to get a repl. Thanks again! Hope you keep contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178