[codex] fix issue 601 manifest dedupe#602
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #601 by hardening the Claude
update-manifest.mjshook against legacydocs/manifest.jsonentries that omitdocumentId.Root Cause
The manifest dedupe path assumed every existing manifest entry had a string
documentId, then called.replace()while computing the base document ID. Older or partial manifest rows can contain onlypathandtitle, which made the PostToolUse Write hook throw after/arckit:principleswrote a global artifact.Changes
baseId()against missing or non-string values.entryBaseId()so dedupe usesdocumentIdwhen present and falls back to the entry path basename for legacy rows.documentId.Validation
node tests/plugin/test_update_manifest.mjsnode tests/plugin/test_hook_utils.mjsgit diff --check HEAD~1 HEAD