Skip to content

fix!: remove wasm references when wasm feature disabled #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XAMPPRocky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix!: remove wasm references when wasm feature disabled #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/core/src/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ fn init_main_db_impl(
data_dir: Option<&DataDir>,
json_registry: Option<Arc<RwLock<JsonSchemaRegistry>>>,
attach: Vec<AttachedDatabase>,
runtimes: Vec<SqliteFunctionRuntime>,
#[cfg_attr(not(feature = "wasm"), expect(unused))] runtimes: Vec<SqliteFunctionRuntime>,
main_migrations: bool,
) -> Result<(Connection, bool), ConnectionError> {
let main_path = data_dir.map(|d| d.main_db_path());
Expand Down
3 changes: 2 additions & 1 deletion crates/core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ mod wasm {
}
}

#[derive(Clone)]
pub struct SqliteFunctionRuntime;

pub struct WasmRuntimeResult {
Expand All @@ -77,7 +78,7 @@ mod wasm {

pub fn build_sync_wasm_runtimes_for_components(
_components_path: PathBuf,
_fs_root_path: Option<PathBuf>,
_fs_root_path: Option<&std::path::Path>,
_dev: bool,
) -> Result<Vec<SqliteFunctionRuntime>, AnyError> {
return Ok(vec![]);
Expand Down
Loading