perf: lazy load Kaitai parsers and remove unused imports #3443
+30
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESultanik
force-pushed
the
perf/lazy-kaitai
branch
2 times, most recently
from
41e74cc to
61aa87e
Compare
Make Kaitai struct parsers lazy-loaded by deferring the KaitaiParser.load() call until the parser is first invoked. Previously, all 31 Kaitai parsers were loaded at import time even if the file type was never encountered. Also removes unused imports (Gif, Jpeg, Png) that were imported at module level but never used. Changes: - Add LazyKaitaiParser class that wraps parser loading - Remove unused Gif, Jpeg, Png imports from kaitaimatcher.py - Parsers are now loaded on-demand when first parsing a matching file Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ESultanik
force-pushed
the
perf/lazy-kaitai
branch
from
61aa87e to
9597a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KaitaiParser.load()until first useImplementation
LazyKaitaiParserclass that wraps the actual parser loadingKaitaiParser.load()is deferred until__call__from .kaitai.parsers.gif import Gifetc. were unusedPerformance Results
When combined with other lazy loading optimizations, Kaitai parsers no longer contribute to import time overhead. Parsers for rarely-used formats (RPM, XAR, DOOM, etc.) are only loaded when matching those file types.
Test plan
pytest tests/test_magic.py tests/test_kaitai.py- same test results as baseline🤖 Generated with Claude Code