Skip to content

Fix 'episode' type for 'watch until here' i18n value from 'number' to 'string' #1967

Open
tysonkerridge wants to merge 1 commit intomainfrom
fix/i18n-watch-until
Open

Fix 'episode' type for 'watch until here' i18n value from 'number' to 'string' #1967
tysonkerridge wants to merge 1 commit intomainfrom
fix/i18n-watch-until

Conversation

@tysonkerridge
Copy link
Collaborator

The existing type was a number which lead to being an Int in Swift (as expected from a config perspective) however the text needed there needs to be more than just the episode number and therefore requires a String.

Eg. if you're marking season 2 episode 2 as watched, it shouldn't say

{...} until episode 2 {...}

and instead should be more like

{...} until episode 2x2 {...}

or even (with actual content changes)

{...} until S2 E2 {...}

It appears that the web client already gets around the issue either deliberately or accidentally (see below), however Swift won't let me do that and wants an Int:

episode: `${lastSeason.number}x${lastEpisode.number}`,

@seferturan As far as I understand, this won't actually break anything on the web client, but I assume it's probably only the spot above at worst.

Note: The actual removal of "ios" from the exclude param will be in a separate bulk PR.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the data type for the 'episode' field within the i18n configuration. This change is necessary to support more flexible episode naming conventions, such as '2x2' or 'S2 E2', which cannot be represented by a simple integer. This adjustment ensures consistency and prevents type-related errors in environments like Swift that strictly enforce these definitions.

Highlights

  • Type definition update: Updated the 'episode' field type from 'number' to 'string' in the i18n metadata configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@trakt-bot trakt-bot bot enabled auto-merge (rebase) March 27, 2026 03:51
@deepsource-io
Copy link

deepsource-io bot commented Mar 27, 2026

DeepSource Code Review

We reviewed changes in dad6a63...a5c5a04 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Mar 27, 2026 3:58a.m. Review ↗
Test coverage Mar 27, 2026 3:58a.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
80.7%
[▲ up 0.1% from main]
Javascript
80.7%
[▲ up 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the metadata schema in the English localization file, specifically changing the data type of the episode field from a number to a string. I have no feedback to provide.

…atched_show_until

The existing 'episode' type was a number, which compiled to an `Int` in Swift. However, the display text needs to show both season and episode (e.g., "2x2" or "S2 E2"), which requires a `String`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant