Fix 'episode' type for 'watch until here' i18n value from 'number' to 'string' #1967
Fix 'episode' type for 'watch until here' i18n value from 'number' to 'string' #1967tysonkerridge wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the data type for the 'episode' field within the i18n configuration. This change is necessary to support more flexible episode naming conventions, such as '2x2' or 'S2 E2', which cannot be represented by a simple integer. This adjustment ensures consistency and prevents type-related errors in environments like Swift that strictly enforce these definitions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Mar 27, 2026 3:58a.m. | Review ↗ | |
| Test coverage | Mar 27, 2026 3:58a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 80.7% [▲ up 0.1% from main] |
| Javascript | 80.7% [▲ up 0.1% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
b6baebf to
393e28d
Compare
…atched_show_until The existing 'episode' type was a number, which compiled to an `Int` in Swift. However, the display text needs to show both season and episode (e.g., "2x2" or "S2 E2"), which requires a `String`.
393e28d to
a5c5a04
Compare
The existing type was a number which lead to being an
Intin Swift (as expected from a config perspective) however the text needed there needs to be more than just the episode number and therefore requires aString.Eg. if you're marking season 2 episode 2 as watched, it shouldn't say
and instead should be more like
or even (with actual content changes)
It appears that the web client already gets around the issue either deliberately or accidentally (see below), however Swift won't let me do that and wants an
Int:trakt-web/projects/client/src/lib/features/confirmation/_internal/getWarningMessage.ts
Line 34 in dad6a63
@seferturan As far as I understand, this won't actually break anything on the web client, but I assume it's probably only the spot above at worst.
Note: The actual removal of
"ios"from theexcludeparam will be in a separate bulk PR.