Patched out forcing references in query arguments#3899
Closed
Buzzec wants to merge 2 commits into
Closed
Conversation
Collaborator
This is a net negative for most usages. We deliberately designed the macros not to require manual references because that's really surprising compared to macros like This really needs to be a part of a larger conversation where we decide whether to drop the borrowing from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a breaking change?
This is a breaking change, it makes arguments no longer forced to be references. Users will have to manually reference their arguments.
Reasoning
This allows returning owned values as part of outputs, such as a function that outputs a stream from a
fetchcall can have values that are passed to that function as args.We are already using this patch in our large codebase as it allows for optimized returns for streams.