For "forced_beam": limit brightness correction#184
Merged
HannoSpreeuw merged 1 commit intomasterfrom Nov 30, 2025
Merged
Conversation
Fixes issue 180. What we have seen is that there are wider islands where the position of the pixel with the maximum value is several pixels away from the island's barycenter position. When the beam shape is forced to be as small as the clean beam, the extrapolation from the maximum pixel position to the barycenter position fails, i.e. the derived brightness value at the barycenter becomes huge. This fix limits the extrapolations from the rounded barycenter position to the barycenter position such that the subtended angle of interpolation remains at the subpixel level. This bug did not show up when designing our two extensive "test_measured_vectorized_forced_beam" (167,281 inserted sources) and "test_measured_vectorized_free_shape" (90,000 inserted sources) regression tests, probably because these artificial sources are "well-formed" and do not share the peculiarities of sources in real aperture synthesis images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180
What we have seen is that there are wider islands where the position of the pixel with the maximum value is several pixels away from the island's barycenter position. When the beam shape is forced to be as small as the clean beam, the extrapolation from the maximum pixel position to the barycenter position fails, i.e. the derived brightness value at the barycenter becomes huge. This fix limits the extrapolations from the rounded barycenter position to the barycenter position such that the subtended angle of interpolation remains at the subpixel level. This bug did not show up when designing our two extensive test_measured_vectorized_forced_beam (167,281 inserted sources) and test_measured_vectorized_free_shape (90,000 inserted sources) regression tests, probably because these artificial sources are "well-formed" and do not share the peculiarities of sources in real aperture synthesis images.