Drop service accounts from witness terraform #403
Merged
+34
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
witness_tf_update
branch
from
5dfef4d to
e67bf91
Compare
AlCutter
changed the title
roger2hk
approved these changes
Feb 2, 2026
phbnf
approved these changes
Feb 2, 2026
AlCutter
force-pushed
the
witness_tf_update
branch
from
e67bf91 to
45ddb4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage ? 29.88%
=======================================
Files ? 8
Lines ? 532
Branches ? 0
=======================================
Hits ? 159
Misses ? 346
Partials ? 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlCutter
force-pushed
the
witness_tf_update
branch
from
45ddb4e to
57d24f8
Compare
phbnf
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR externalises ownership/creation of the service accounts and witness secret naming from terraform.