Name buckets after origin for GCE deployment #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbnf
force-pushed
the
dnsbucket
branch
2 times, most recently
from
2c2f2f7 to
d94596e
Compare
AlCutter
approved these changes
Jan 28, 2026
| } | ||
|
|
||
| variable "bucket_name" { | ||
| description = "Name of the GCS bucket. Defaults to '${var.project_id-base}_${var.base_name}-bucket if unspecicfied" |
Collaborator
There was a problem hiding this comment.
Suggested change
| description = "Name of the GCS bucket. Defaults to '${var.project_id-base}_${var.base_name}-bucket if unspecicfied" | |
| description = "Name of the GCS bucket. Defaults to '${var.project_id-base}-${var.base_name}-bucket if unspecicfied" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This names bucket after the origin by default for GCE deployments, leaving an escape hatch.
Other deployments (cloudrun, test) will use the legacy naming scheme
{project_id}-{base_name}-bucket.