Clear flags when reversing prior to do other manual corrections#4
Open
Akronix wants to merge 2 commits intotreenet:masterfrom
Open
Clear flags when reversing prior to do other manual corrections#4Akronix wants to merge 2 commits intotreenet:masterfrom
Akronix wants to merge 2 commits intotreenet:masterfrom
Conversation
Firts clear flags of previous changes made by treenetproc, add the 'rev' flag and then do the other manual corrections. This comes out from the need that sometimes we want to reverse a change made by treenetproc and, at the same item position, force a jump. With the previous code, the force jump got a NA value since there was a 'fill' flag when the forcejump function was executing (see second statement of the forcejump function). This was because removing the previous flags and setting the 'rev' flag was done after all the corrections are made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firts clear flags of previous changes made by treenetproc, add the 'rev' flag and then do the other manual corrections.
This comes out from the need that sometimes we want to reverse a change made by treenetproc and, at the same item position, force a jump. With the previous code, the force jump got a NA value since there was a 'fill' flag when the forcejump function was executing (see second statement of the forcejump function). This was because removing the previous flags and setting the 'rev' flag was done after all the corrections are made.