fix: report unhandled errors as NFS SERVERFAULT, not an RPC fault - #9
Open
AliRamberg wants to merge 1 commit into
Open
fix: report unhandled errors as NFS SERVERFAULT, not an RPC fault#9AliRamberg wants to merge 1 commit into
AliRamberg wants to merge 1 commit into
Conversation
An error a procedure handler returns that is neither an RPCError nor an NFSStatusError was formatted as ResponseCodeSystemError, an RPC-level accept_stat fault. A fault signals a malformed RPC, which some clients (macOS surfaces it as EBADRPC) turn into a failed syscall rather than a normal filesystem error. Map such errors to the NFS status SERVERFAULT inside an accepted reply so the client receives an ordinary I/O error instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An error a procedure handler returns that is neither an RPCError nor an NFSStatusError was formatted as ResponseCodeSystemError, an RPC-level accept_stat fault. A fault signals a malformed RPC, which some clients (macOS surfaces it as EBADRPC) turn into a failed syscall rather than a normal filesystem error.
Map such errors to the NFS status SERVERFAULT inside an accepted reply so the client receives an ordinary I/O error instead.