test: strengthen local CLI coverage#40
Merged
TrevorBasinger merged 6 commits intomainfrom Mar 17, 2026
Merged
Conversation
feat: auto-label detected composite datasets
christophergeyer
approved these changes
Mar 17, 2026
Member
christophergeyer
left a comment
There was a problem hiding this comment.
Cool - I'll try to run a smoke test on it.
Might there be conflicts with the backend speedup PR which batches db inserts?
Member
Author
I just approved and merged that PR for you. Looks likes it didn't create any conflicts for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This PR raises confidence in the real
roarCLI by shifting more of the suite toward local product-path coverage instead of thin mocked wrappers.It adds subprocess coverage across the main CLI surfaces, brings the stronger local integration layer into the default gate, and trims duplicated wrapper and DAG happy-path tests so the suite stays focused on real command behavior.
It also adds automatic local labels for detected dataset composite artifacts. When
roardetects that a run output is a dataset-like composite, it now attaches system-managed dataset labels to that artifact automatically. This starts moving dataset identity toward the label system without removing the existing metadata path yet.Why
The main goal is to make the default local test signal better reflect what users actually run. That means preferring end-to-end CLI paths where possible, keeping mocks for narrow assumptions only, and reducing duplicated scenarios that slow the suite down without adding much confidence.
The dataset label change is part of the same direction: detected datasets should become queryable and discoverable through labels automatically, rather than relying only on artifact metadata.
Notes
Existing non-dataset labels on an artifact are preserved. The auto-managed dataset label subtree is only updated when the detected dataset values change.
Testing
ruff check .mypy roarpytest -m "not live_glaas and not ebpf"