use as_chunks for adler32 generic version#518
Draft
folkertdev wants to merge 1 commit into
Draft
Conversation
folkertdev
force-pushed
the
adler32-generic-small-input
branch
from
07f61c8 to
52c26f6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
folkertdev
force-pushed
the
adler32-generic-small-input
branch
from
afbcb48 to
52c26f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves about 4% on 1kb inputs on
loongarch64(an architecture that we don't have a simd implementation for that I have access too).It adds a decent amount of
unsafecode. It's trivial and copied from the standard library , but still kind of unfortunate. More and more I feel that we should bump our MSRV, and when we do, we may as well make a big jump.