Feat(webapp) chat AI UI improvements, new task landing pages and side menu#3941
Open
samejr wants to merge 132 commits into
Open
Feat(webapp) chat AI UI improvements, new task landing pages and side menu#3941samejr wants to merge 132 commits into
samejr wants to merge 132 commits into
Conversation
Conflicts: - AgentMessageView.tsx, AgentView.tsx: kept both sides. - schedules/route.tsx: deletion preserved; the purchase modal and usage bar have been moved into the Scheduled Task landing page with a new shared resource action route. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
|
Important Review skippedToo many files! This PR contains 152 files, which is 2 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (152)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+124
to
+143
| {/* {isUsingPlugin && ( */} | ||
| {/* {featureFlags.hasPrivateConnections && ( */} | ||
| <SideMenuItem | ||
| name="Private Connections" | ||
| icon={PadlockIcon} | ||
| activeIconColor="text-text-bright" | ||
| inactiveIconColor="text-text-dimmed" | ||
| to={v3PrivateConnectionsPath(organization)} | ||
| data-action="private-connections" | ||
| /> | ||
| {/* )} */} | ||
| <SideMenuItem | ||
| name="Roles" | ||
| icon={RolesIcon} | ||
| activeIconColor="text-text-bright" | ||
| inactiveIconColor="text-text-dimmed" | ||
| to={organizationRolesPath(organization)} | ||
| data-action="roles" | ||
| /> | ||
| {/* )} */} |
Contributor
There was a problem hiding this comment.
🚩 Feature flag guards for Private Connections and Roles removed from sidebar — routes still guard access
The hasPrivateConnections feature flag guard and the isUsingPlugin guard for Roles have been commented out (apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx:124-143), making both menu items visible to all users regardless of their entitlements. This is not a bug because the route loaders themselves still enforce access: _app.orgs.$organizationSlug.settings.private-connections._index/route.tsx calls canAccessPrivateConnections() (which checks the hasPrivateConnections feature flag in apps/webapp/app/v3/canAccessPrivateConnections.server.ts), and the Roles route checks rbac.isUsingPlugin(). However, users without access will now see a link in the sidebar that leads to a page that may redirect or show an error/upsell, which could be a confusing UX. The commented-out guards ({/* {isUsingPlugin && ( */}, {/* {featureFlags.hasPrivateConnections && ( */}) suggest this might be a WIP change that needs cleanup before merge.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
✅ Checklist
Testing
[Describe the steps you took to test this change]
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯