Skip to content

fix: resolve labels field options using "label" key #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neptunix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve labels field options using "label" key #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions pkg/cmd/task/custom_fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func resolveDropdownOption(field *clickup.CustomField, optionName string) (inter
}

for _, opt := range options {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
if strings.EqualFold(name, optionName) {
if id, ok := opt["id"].(string); ok {
return id, nil
Expand Down Expand Up @@ -144,7 +144,7 @@ func resolveLabelOptions(field *clickup.CustomField, rawValue string) (interface
}
found := false
for _, opt := range options {
if optName, ok := opt["name"].(string); ok {
if optName := getOptionName(opt); optName != "" {
if strings.EqualFold(optName, name) {
if id, ok := opt["id"].(string); ok {
ids = append(ids, id)
Expand Down Expand Up @@ -206,11 +206,23 @@ func extractTypeConfigOptions(typeConfig interface{}) []map[string]interface{} {
return result
}

// getOptionName returns the display name for a custom field option.
// Dropdown fields use the "name" key, while labels fields use "label".
func getOptionName(opt map[string]interface{}) string {
if name, ok := opt["name"].(string); ok {
return name
}
if label, ok := opt["label"].(string); ok {
return label
}
return ""
}

// listOptionNames returns a comma-separated list of option names.
func listOptionNames(options []map[string]interface{}) string {
var names []string
for _, opt := range options {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
names = append(names, name)
}
}
Expand Down Expand Up @@ -340,7 +352,7 @@ func formatDropdownValue(field clickup.CustomField) string {
options := extractTypeConfigOptions(field.TypeConfig)
for _, opt := range options {
if id, ok := opt["id"].(string); ok && id == s {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
return name
}
}
Expand All @@ -354,7 +366,7 @@ func formatDropdownValue(field clickup.CustomField) string {
idx := int(optionIdx)
for _, opt := range options {
if orderIdx, ok := opt["orderindex"].(float64); ok && int(orderIdx) == idx {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
return name
}
}
Expand All @@ -373,7 +385,7 @@ func formatLabelsValue(field clickup.CustomField) string {
optionMap := make(map[string]string)
for _, opt := range options {
if id, ok := opt["id"].(string); ok {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
optionMap[id] = name
}
}
Expand All @@ -392,7 +404,7 @@ func formatLabelsValue(field clickup.CustomField) string {
idx := int(val)
for _, opt := range options {
if orderIdx, ok := opt["orderindex"].(float64); ok && int(orderIdx) == idx {
if name, ok := opt["name"].(string); ok {
if name := getOptionName(opt); name != "" {
names = append(names, name)
}
}
Expand Down
Loading