Skip to content

Change publish_test.yaml to not run on main#18

Merged
bbengfort merged 3 commits intomainfrom
chrisokuda/publish_test_fix-2025_08_04
Aug 4, 2025
Merged

Change publish_test.yaml to not run on main#18
bbengfort merged 3 commits intomainfrom
chrisokuda/publish_test_fix-2025_08_04

Conversation

@chris-okuda
Copy link
Copy Markdown
Collaborator

@chris-okuda chris-okuda commented Aug 4, 2025

Scope of changes

Change publish_test.yaml to not run on main because it will usually always fail since the version doesn't change from the PR upload that it was merged from, and this is only helpful for in a PR context anways. The test-pypi distribution will only happen on PRs.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

No special needs.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • To the best of my ability, I believe that this PR represents a good solution to the specified problem and that it should be merged into the main code base.

The test-pypi distribution will only happen on PRs and when a version tag (`v*`) is added.

Signed-off-by: Chris Okuda <chris@rotational.io>
@chris-okuda chris-okuda self-assigned this Aug 4, 2025
@chris-okuda chris-okuda added the bug Something isn't working label Aug 4, 2025
Signed-off-by: Chris Okuda <chris@rotational.io>
Signed-off-by: Chris Okuda <chris@rotational.io>
@bbengfort bbengfort merged commit 359835d into main Aug 4, 2025
4 checks passed
@bbengfort bbengfort deleted the chrisokuda/publish_test_fix-2025_08_04 branch August 4, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants