fix: Verify MemoryShm::byte_size inside shared memory boundary#406
Merged
fix: Verify MemoryShm::byte_size inside shared memory boundary#406
Conversation
Contributor
Author
|
No unit test because triton-inference-server/server#8273 makes the exploitation impossible. |
Tabrizian
approved these changes
Jul 3, 2025
tanmayv25
approved these changes
Jul 4, 2025
Contributor
Author
|
@Tabrizian @tanmayv25 @pskiran1 I pushed a new commit 595a488 to fix the CI. Somehow the setting of this repo does not enforce re-approval. Please add an emoji if the change looks good. Thanks. |
mc-nv
pushed a commit
that referenced
this pull request
Jul 23, 2025
mc-nv
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
When attacker registers the same shm created by python backend, they can overwrite
MemoryShm::byte_sizedata with a very large value. Identity model will read a large chunk of sensitive data (e.g. glibc.so) as input tensor, copy to the output tensor and send back to the client.Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
Where should the reviewer start?
Test plan:
31182731
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)