Merged
Conversation
whoisj
force-pushed
the
jwyman/tri-229-integer-overflow-in-http-server-byte-string-processing
branch
from
583d78e to
a9923b5
Compare
yinggeh
reviewed
Nov 5, 2025
yinggeh
reviewed
Nov 5, 2025
whoisj
force-pushed
the
jwyman/tri-229-integer-overflow-in-http-server-byte-string-processing
branch
from
7880104 to
c4158a6
Compare
yinggeh
previously approved these changes
Nov 5, 2025
This change adds a sanity check prior to a static cast of `int32_t` to `int64_t` to use as an offset. While the current code cannot enter this state, this protects against future changes. Co-authored-by: Yingge He <157551214+yinggeh@users.noreply.github.com>
whoisj
force-pushed
the
jwyman/tri-229-integer-overflow-in-http-server-byte-string-processing
branch
from
c4158a6 to
815fefb
Compare
yinggeh
approved these changes
Nov 6, 2025
whoisj
deleted the
jwyman/tri-229-integer-overflow-in-http-server-byte-string-processing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a sanity check prior to a static cast of
int32_ttoint64_tto use as an offset.While the current code cannot enter this state, this protects against future changes.