Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to detect when a Python backend stub process becomes unresponsive or crashes. The implementation includes comprehensive test coverage to verify that the model ready status accurately reflects the health of the underlying stub process.
Key changes:
- Added a new test suite to verify model ready checks detect crashed stub processes
- Tests simulate process failures using different signals (SIGSEGV and SIGKILL)
- Validates both HTTP and gRPC endpoints report correct model readiness status
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| qa/L0_backend_python/test.sh | Adds new model_ready_check test to the test suite execution |
| qa/L0_backend_python/model_ready_check/test.sh | Test script that simulates stub process crashes and verifies model ready status |
| qa/L0_backend_python/model_ready_check/check_model_ready.py | Python test cases for checking model ready status via HTTP and gRPC |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pskiran1
changed the title
…to-be-healthy-when-using
whoisj
previously approved these changes
Dec 5, 2025
yinggeh
previously approved these changes
Dec 8, 2025
yinggeh
previously approved these changes
Dec 8, 2025
…to-be-healthy-when-using
yinggeh
reviewed
Dec 8, 2025
yinggeh
reviewed
Dec 8, 2025
yinggeh
approved these changes
Dec 8, 2025
Contributor
|
Please also document in |
pskiran1
deleted the
spolisetty/tri-231-backend-endpoint-reports-to-be-healthy-when-using
branch
mc-nv
pushed a commit
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR includes comprehensive test coverage to verify that the model ready status accurately reflects the health of the underlying stub process.
Key changes:
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)