Conversation
max_inflight_requests as a global per-step limit across ensemble requestsmax_inflight_requests as a global per-step limit across ensemble requests
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the L0 simple ensemble QA tests to validate that max_inflight_requests behaves as a global per-step limit when multiple ensemble requests and multi-step pipelines are involved.
Changes:
- Refactors
qa/L0_simple_ensemble/test.shto build dedicated model repositories for max-queue-size step testing and for multi-step backpressure (max_inflight_requests) scenarios, and to improve failure logging. - Reworks
qa/L0_simple_ensemble/ensemble_backpressure_test.pyto add concurrent, sequential, and cancellation scenarios across multiplemax_inflight_requestsconfigurations, and adds optional batched-input shaping for the new ensemble models.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
qa/L0_simple_ensemble/test.sh |
Builds new model repos for the updated backpressure tests and adjusts test execution / expected counts. |
qa/L0_simple_ensemble/ensemble_backpressure_test.py |
Adds new backpressure test cases and changes request tensor shaping for batched ensemble configs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Updates the L0 simple ensemble QA tests to validate that
max_inflight_requestsbehaves as a global per-step limit when multiple ensemble requests and multi-step pipelines are involved.Changes:
qa/L0_simple_ensemble/test.shto build dedicated model repositories for max-queue-size step testing and for multi-step backpressure (max_inflight_requests) scenarios, and to improve failure logging.qa/L0_simple_ensemble/ensemble_backpressure_test.pyto add concurrent, sequential, and cancellation scenarios across multiplemax_inflight_requestsconfigurations, and adds optional batched-input shaping for the new ensemble models.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
max_inflight_requestsas a global per-step limit across ensemble requests core#482max_inflight_requestsas a global per-step limit across ensemble requests common#152Where should the reviewer start?
Test plan:
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
max_inflight_requestsfunctionality for whole ensemble (rather than per-request) #8597