[draft] use flash_attention from cuda-free#12
Draft
sijiac wants to merge 1 commit intotriton-lang:mainfrom
Draft
[draft] use flash_attention from cuda-free#12sijiac wants to merge 1 commit intotriton-lang:mainfrom
sijiac wants to merge 1 commit intotriton-lang:mainfrom
Conversation
Collaborator
|
can you run with benchmarking turned on and see the difference? would be curious to see the attention specific latency here :) in that case you dont need to specify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By switching to use the attention from the
cuda-freerepo, the Triton attention now works well for thekernelsrepoThe missing part of the attention kernel of
kernelsrepo is it doesn’t support the decoding case, where the length of Q and the length of K is different for the same batchpython3 -m main llama_chat_completion --profile=False --benchmark=False --ckpt_dir="/home/sijiac/models/Meta-Llama-3-8B-Instruct/" --tokenizer_path="/home/sijiac/models/Meta-Llama-3-8B-Instruct/tokenizer.model" --use_triton=True