Framework RHS Splitting and MIS Method#2058
Closed
MarcoArtiano wants to merge 7 commits into
Closed
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Contributor
Author
|
Feature implemented in #2518. MIS methods will be implemented in Ariadne.jl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first dirty implementation of a general framework for RHS splitting as well as MIS Method.
MIS Method reference
Wensch, J., Knoth, O. & Galant, A. Multirate infinitesimal step methods for atmospheric flow simulation. Bit Numer Math 49, 449–473 (2009). https://doi.org/10.1007/s10543-009-0222-3
The ODE is solved using RK4.
The linear acoustic-advection system has also been added as a test case.
Since many improvements and addition has still to be done, at the moment the PR is still not ready for a review.
ps: I need to implement how to deal with step callbacks when the rhs is splitted.