Open
Conversation
…(keep existing compat)
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.42.1 to 1.43.3. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.42.1...v1.43.3) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.43.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…-08-00-28-43-503-03382000766' into bg/fix-retcode-check
…-08-00-29-24-487-00230620603' into bg/fix-retcode-check
…-20-00-20-01-226-02439714846' into bg/fix-retcode-check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 25 25
Lines 1260 1260
Branches 74 74
=======================================
Hits 1211 1211
Misses 45 45
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benegee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR originates from: https://github.com/trixi-framework/libtrixi/actions/runs/21808243190/job/62915273766#step:19:211
According to the docs (https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#SciMLBase.ReturnCode) the return code has be checked for success differently, and this is what I did.
I am not sure which version actually introduced the change which made the old check fail, nor do I know which version introduced support for the new check.
Instead, I decided to move to the split OrdinaryDiffEq packages, which I wanted to do at some point anyway.
Doing so, I realized we actually do not need OrdinaryDiffEq in LibTrixi.jl itself (just like with Trixi.jl).
Remaining questions @sloede
libtrixi/LibTrixi.jl/test/Project.toml
Line 10 in f5fffee