feat: add --watch flag to deploy update#22
Merged
Conversation
xaviedoanhduy
force-pushed
the
feat/update-watch-flag
branch
from
d934461 to
ea1bfd3
Compare
hailangvn
reviewed
May 5, 2026
Collaborator
hailangvn
left a comment
hailangvn
left a comment
There was a problem hiding this comment.
Thanks for the work. Please consider the change. Thank you.
After a successful update, stream service logs via journalctl when --watch is passed. Ctrl+C stops the log tail cleanly. - executor: add stream() method for long-lived commands that pipe output directly to the terminal without capturing - update: add --watch flag; calls journalctl --user -u <instance> -f - tests: verify stream() is called with the right command, not called without --watch, and KeyboardInterrupt is handled gracefully Closes #20 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xaviedoanhduy
force-pushed
the
feat/update-watch-flag
branch
from
ea1bfd3 to
ece738f
Compare
Member
Author
|
hi @hailangvn, I've already applied then |
hailangvn
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--watchflag todeploy update: after a successful deployment, streams service logs withjournalctl --user -u <instance> -fExecutor.stream()method for long-lived commands that must pipe output directly to the terminal (no output capture)Usage
Test plan
--watch, KeyboardInterrupt handled gracefullydeploy update --helpshows--watchoptionCloses #20
🤖 Generated with Claude Code