Silence bogus "Packet ... received on wrong socket" warning#44
Merged
troglobit merged 1 commit intotroglobit:masterfrom Mar 10, 2026
Merged
Conversation
Compare binary instead of string group addresses to decide whether a received packet is for the expected group. This avoids bogus warnings in case of different string representations for the same address, e.g. ff0e::1, [ff0e::1] and ff0E::1 which are all the same group but the latter 2 would have resulted in warnings so far. Also fixes a potential dereference of and uninitialized dst pointer in the unlikely event that we don't have IPv6 support and find_dstaddr() returned NULL. Signed-off-by: Martin Buck <mb-tmp-tvguho.pbz@gromit.dyndns.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare binary instead of string group addresses to decide whether a received packet is for the expected group. This avoids bogus warnings in case of different string representations for the same address, e.g. ff0e::1, [ff0e::1] and ff0E::1 which are all the same group but the latter 2 would have resulted in warnings so far.
Also fixes a potential dereference of and uninitialized dst pointer in the unlikely event that we don't have IPv6 support and find_dstaddr() returned NULL.