Skip to content

Use List/ListItem components from mui#20

Open
ababol wants to merge 6 commits into
troutowicz:masterfrom
ababol:ababol/mui/list
Open

Use List/ListItem components from mui#20
ababol wants to merge 6 commits into
troutowicz:masterfrom
ababol:ababol/mui/list

Conversation

@ababol

@ababol ababol commented Jul 6, 2015

Copy link
Copy Markdown
Contributor

Use List/ListItem components from mui.

We have to use my fork of material-ui but as soon as they have fixed the issue with the utils/extends, we will switch again ;).

Fix #18

@troutowicz

Copy link
Copy Markdown
Owner

Awesome, I'll take a closer look at this soon!

@ababol ababol force-pushed the ababol/mui/list branch from 0cf0f1c to 8c07ad9 Compare July 6, 2015 21:32
Comment thread app/components/List.jsx Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import List from 'material-ui/lib/lists/list';

@troutowicz

Copy link
Copy Markdown
Owner

We still need to figure out why ReactCSSTransitionGroup is broke.

@troutowicz

Copy link
Copy Markdown
Owner

Another issue I forgot to mention is the ListItem on click ripple color needs to be tweaked.

@ababol

ababol commented Jul 14, 2015

Copy link
Copy Markdown
Contributor Author

Good point 👍 , I have made the changes.

@ababol

ababol commented Jul 19, 2015

Copy link
Copy Markdown
Contributor Author

Hey @troutowicz, did you have time to take a look at the ReactCSSTransitionGroup issue?

I will probably investigate further next week.

@troutowicz

Copy link
Copy Markdown
Owner

I have not, my schedule has been and will be packed through mid this week. Let me know what your investigations turn up. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Material-UI's List

2 participants