refactor: detect_warmup registry pattern - #72
Merged
Conversation
Each strategy now has a warmup_indicators(cls, data) classmethod that returns indicator Series for warmup detection. detect_warmup() calls it generically — no more per-strategy branches. Adding new strategies no longer requires editing detect_warmup(). Fixes #59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Replaces the monolithic if/elif chain in
detect_warmup()with a classmethod-based registry.Each strategy now has
warmup_indicators(cls, data)returning its indicator Series.detect_warmup()calls it generically — adding new strategies no longer requires editing the function.All 128 tests pass unchanged.