fix: read body from stdin when --tags or template is set - #1
Open
shichenshuo-star wants to merge 1 commit into
Open
fix: read body from stdin when --tags or template is set#1shichenshuo-star wants to merge 1 commit into
shichenshuo-star wants to merge 1 commit into
Conversation
The stdin guard used note_content.is_empty(), but --tags or a template populate note_content with frontmatter before the body is read, so stdin was silently skipped and the note body was dropped. Now stdin is read whenever -c/--content is not provided and stdin is not a TTY, appending the body after any existing frontmatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
obscli note create <name> --tags a,bsilently drops the note body when thecontent is piped via stdin. The
-c/--contenthelp says "(reads from stdin ifnot provided)", but with
--tagsthe body never appears in the created file.Reproduction
Root cause
In
src/plugins/files.rs,cmd_createreads stdin only whennote_content.is_empty():But when
--tags(or-t/--template) is provided, frontmatter is written intonote_contentbefore this block runs, so the guard is false and stdin isnever read — the body is silently dropped.
Fix
Read stdin whenever
-c/--contentis not provided and stdin is not a TTY,appending the body after any existing frontmatter:
Verification
Tested against a local build (debug):
--tags a,b+ stdin → frontmatter + full body ✅-c+--tags→ frontmatter + body ✅ (no regression)