Check weighted sidecar arithmetic - #102
Closed
MesTTo wants to merge 4 commits into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checked arithmetic to the weighted path sidecar.
set_weight,apply_delta,selection_tree, andselect_by_offset_treenow report typed arithmetic errors instead of saturating or silently publishing an incorrect positive-weight total. The tests cover signed delta overflow, total positive-weight overflow, and no-mutation behavior on rejected updates.Depends on #101.
Validation:
CARGO_HOME=/home/user/Dev/.cargo-isolated RUSTFLAGS='-C target-cpu=native -Awarnings' cargo +nightly test -p mork --libCARGO_HOME=/home/user/Dev/.cargo-isolated RUSTFLAGS='-C target-cpu=native -Awarnings' cargo +nightly test -p mork --testsrustfmt --check kernel/src/weighted_paths.rs kernel/tests/public_api.rs kernel/tests/weighted_paths.rsjscpd --reporters ai --min-lines 5 --min-tokens 50 kernel/src/weighted_paths.rs kernel/tests/public_api.rs kernel/tests/weighted_paths.rsgit diff --check