Add einsum output-shape inference - #112
Open
MesTTo wants to merge 2 commits into
Open
Conversation
…shapes The dims-resolution loop in infer_output_shapes was a near-verbatim copy of the one in compile, differing only in reading dimensions from a shape slice instead of NDIndex. Factor it into resolve_slot_dims, parameterized over how an input's rank and dimensions are read, and call it from both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
einsum::infer_output_shapes, which computes the output shapes of an explicitlhs->rhseinsum spec from the input shapes, without running the contraction.It follows the same contract as
einsum: every input subscript labels one input axis, repeated labels must agree on their dimension, and each output subscript must be bound by some input. It returnsInvalidSpecon an input-arity mismatch or a dimension mismatch, reusing the existing error type.Purely additive (no changes to existing code or formatting).
The tests cover both paths:
ab,bc->acover[2,3]and[3,4]is[2,4]InvalidSpec::DimensionMismatchValidation:
CARGO_HOME=/home/user/Dev/.cargo-isolated RUSTFLAGS='-C target-cpu=native -Awarnings' cargo +nightly test -p linalg infer_output_shapesgit diff --check