Optimize unifier pair handling - #63
Closed
MesTTo wants to merge 1 commit into
Closed
Conversation
MesTTo
marked this pull request as ready for review
June 23, 2026 10:23
Contributor
Author
|
Closing per the kernel gate on constant-factor speed-ups (same basis as #126/#127): this reduces unifier work without changing semantics (dropping identical dereferenced pairs, hashing the seen-pair guard once instead of twice), a constant-factor optimization rather than an asymptotic one. The asymptotic version would be replacing the (ExprEnv,ExprEnv) hash-set guard with a union-find trail; parking this micro-opt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces work in the expression unifier without changing unification semantics.
The branch drops identical dereferenced pairs before descending them and uses
HashSet::insertas the seen-pair guard instead of hashing once forcontainsand again forinsert.Validation:
cargo +nightly-2026-06-01 test -p mork-exprwithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'jscpdonexpr/src/lib.rsgit diff --check