Skip to content

Add term identity sidecar - #66

Closed
MesTTo wants to merge 1 commit into
trueagi-io:mainfrom
MesTTo:pr/mork-term-identity-sidecar
Closed

Add term identity sidecar#66
MesTTo wants to merge 1 commit into
trueagi-io:mainfrom
MesTTo:pr/mork-term-identity-sidecar

Conversation

@MesTTo

@MesTTo MesTTo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Adds a derived term identity sidecar for encoded MORK facts and subterms.

The branch interns complete facts and subterms from encoded paths, records stable TermId and FactId values, caches ground/schematic flags, and exposes read-only counters. The sidecar is derived from PathMap<()> snapshots and does not change the authoritative atom store.

Validation:

  • cargo +nightly-2026-06-01 test -p mork --test term_identity with RUSTFLAGS='-C target-cpu=native'
  • cargo +nightly-2026-06-01 test -p mork --lib with RUSTFLAGS='-C target-cpu=native'
  • rustfmt --check on kernel/src/term_identity.rs and kernel/tests/term_identity.rs
  • jscpd on kernel/src/term_identity.rs and kernel/tests/term_identity.rs
  • git diff --check

@MesTTo
MesTTo marked this pull request as ready for review June 23, 2026 10:23
@MesTTo

MesTTo commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Folding this into #116, which now contains this base commit plus the follow-ups that address the review direction: the structural hash reuses Expr::hash (gxhash128) instead of the hand-rolled FNV here, the PathMap-coupled extend_from_pathmap is gone, and the fact lifecycle rides on top. #116 is mergeable against current main; this branch conflicts. One PR to review instead of a stale base.

@MesTTo MesTTo closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant