Add term identity sidecar - #66
Closed
MesTTo wants to merge 1 commit into
Closed
Conversation
MesTTo
marked this pull request as ready for review
June 23, 2026 10:23
This was referenced Jun 23, 2026
Contributor
Author
|
Folding this into #116, which now contains this base commit plus the follow-ups that address the review direction: the structural hash reuses Expr::hash (gxhash128) instead of the hand-rolled FNV here, the PathMap-coupled extend_from_pathmap is gone, and the fact lifecycle rides on top. #116 is mergeable against current main; this branch conflicts. One PR to review instead of a stale base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a derived term identity sidecar for encoded MORK facts and subterms.
The branch interns complete facts and subterms from encoded paths, records stable
TermIdandFactIdvalues, caches ground/schematic flags, and exposes read-only counters. The sidecar is derived fromPathMap<()>snapshots and does not change the authoritative atom store.Validation:
cargo +nightly-2026-06-01 test -p mork --test term_identitywithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'rustfmt --checkonkernel/src/term_identity.rsandkernel/tests/term_identity.rsjscpdonkernel/src/term_identity.rsandkernel/tests/term_identity.rsgit diff --check