Select BindingSpace sidecar execution kernel - #82
Closed
MesTTo wants to merge 17 commits into
Closed
Conversation
Contributor
Author
|
Closing: this is part of the un-wired binding_space sidecar that reimplements the kernel's ProductZipper join (generic_join/trie_join/leapfrog) over a parallel term identity instead of reusing Expr/PathMap, and it is not wired to the MeTTa surface. Cost-based execution-kernel selection is also out of scope for the kernel. Parking the whole execution-kernel line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack dependency: review after #81. This branch is based on the prerequisite head. Until the prerequisite PRs merge, GitHub may include their commits in the aggregate diff; the intended review increment is the new commit at this branch tip.
Selects a BindingSpace sidecar execution kernel.
The branch adds a conservative execution choice API for
BindingSidecarPlan. Single-factor, disconnected, and small explicit-input plans stay on the reference Generic Join path. Plans with shared-variable pruning and enough projected rows use the suggested-order trie join.The selected execution result reports the chosen kernel, reason, variable order, projected row count, shared-variable count, and optional trie counters.
Validation:
cargo +nightly-2026-06-01 test -p mork --lib binding_planwithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'rustfmt --checkonkernel/src/binding_plan.rsjscpdonkernel/src/binding_plan.rs,kernel/src/expression_trie.rs,kernel/src/pattern_relations.rs,kernel/src/test_exprs.rs, andkernel/src/test_sidecar_queries.rsgit diff --checkgit diff -w --stat