Skip to content

Trace BindingSpace trie factor participation - #85

Closed
MesTTo wants to merge 20 commits into
trueagi-io:mainfrom
MesTTo:pr/mork-binding-trie-trace-factors
Closed

Trace BindingSpace trie factor participation#85
MesTTo wants to merge 20 commits into
trueagi-io:mainfrom
MesTTo:pr/mork-binding-trie-trace-factors

Conversation

@MesTTo

@MesTTo MesTTo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Stack dependency: review after #84. This branch is based on the prerequisite head. Until the prerequisite PRs merge, GitHub may include their commits in the aggregate diff; the intended review increment is the new commit at this branch tip.

Adds factor participation metadata to BindingSpace trie traces.

The branch records which relation factors participate at each variable-depth trace step and the domain length contributed by each participating relation. The existing trace still records the surviving intersection and cursor counters.

Validation:

  • cargo +nightly-2026-06-01 test -p mork --lib binding_plan with RUSTFLAGS='-C target-cpu=native'
  • cargo +nightly-2026-06-01 test -p mork --lib binding_space with RUSTFLAGS='-C target-cpu=native'
  • cargo +nightly-2026-06-01 test -p mork --lib with RUSTFLAGS='-C target-cpu=native'
  • rustfmt --check on kernel/src/binding_plan.rs and kernel/src/binding_space.rs
  • jscpd on kernel/src/binding_plan.rs, kernel/src/binding_space.rs, kernel/src/expression_trie.rs, kernel/src/pattern_relations.rs, kernel/src/test_exprs.rs, and kernel/src/test_sidecar_queries.rs
  • git diff --check
  • normal diffstat matched git diff -w --stat

@MesTTo

MesTTo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this trace-replay/diff subsystem goes well beyond the simple traversal statistics the kernel would want under a flag, and it instruments the un-wired binding_space join reimplementation rather than the real PathMap/ProductZipper traversal. Parking it (a minimal traversal-counter, pointed at the real zipper, can be revisited separately). Folds into #84.

@MesTTo MesTTo closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant