Skip to content

Add BindingSpace trie trace replay shape - #87

Closed
MesTTo wants to merge 22 commits into
trueagi-io:mainfrom
MesTTo:pr/mork-binding-trie-trace-replay-shape
Closed

Add BindingSpace trie trace replay shape#87
MesTTo wants to merge 22 commits into
trueagi-io:mainfrom
MesTTo:pr/mork-binding-trie-trace-replay-shape

Conversation

@MesTTo

@MesTTo MesTTo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Stack dependency: review after #86. This branch is based on the prerequisite head. Until the prerequisite PRs merge, GitHub may include their commits in the aggregate diff; the intended review increment is the new commit at this branch tip.

Adds BindingSpace trie trace replay shape.

The branch adds a replay tree derived from a TrieJoinTrace. TrieJoinTrace::replay_shape validates the trace, reconstructs the bound-prefix tree, and records branch values and child trace contexts without materializing the joined relation.

The regressions check replay construction against the existing trace fixture and reject a trace whose child context is missing.

Validation:

  • cargo +nightly-2026-06-01 test -p mork --lib binding_space with RUSTFLAGS='-C target-cpu=native'
  • cargo +nightly-2026-06-01 test -p mork --lib with RUSTFLAGS='-C target-cpu=native'
  • rustfmt --check on kernel/src/binding_space.rs
  • jscpd on kernel/src/binding_space.rs, kernel/src/binding_plan.rs, kernel/src/expression_trie.rs, kernel/src/pattern_relations.rs, kernel/src/test_exprs.rs, and kernel/src/test_sidecar_queries.rs
  • git diff --check
  • normal diffstat matched git diff -w --stat

@MesTTo

MesTTo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing: this trace-replay/diff subsystem goes well beyond the simple traversal statistics the kernel would want under a flag, and it instruments the un-wired binding_space join reimplementation rather than the real PathMap/ProductZipper traversal. Parking it (a minimal traversal-counter, pointed at the real zipper, can be revisited separately).

@MesTTo MesTTo closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant