Add BindingSpace trie trace replay shape - #87
Closed
MesTTo wants to merge 22 commits into
Closed
Conversation
Contributor
Author
|
Closing: this trace-replay/diff subsystem goes well beyond the simple traversal statistics the kernel would want under a flag, and it instruments the un-wired binding_space join reimplementation rather than the real PathMap/ProductZipper traversal. Parking it (a minimal traversal-counter, pointed at the real zipper, can be revisited separately). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack dependency: review after #86. This branch is based on the prerequisite head. Until the prerequisite PRs merge, GitHub may include their commits in the aggregate diff; the intended review increment is the new commit at this branch tip.
Adds BindingSpace trie trace replay shape.
The branch adds a replay tree derived from a
TrieJoinTrace.TrieJoinTrace::replay_shapevalidates the trace, reconstructs the bound-prefix tree, and records branch values and child trace contexts without materializing the joined relation.The regressions check replay construction against the existing trace fixture and reject a trace whose child context is missing.
Validation:
cargo +nightly-2026-06-01 test -p mork --lib binding_spacewithRUSTFLAGS='-C target-cpu=native'cargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'rustfmt --checkonkernel/src/binding_space.rsjscpdonkernel/src/binding_space.rs,kernel/src/binding_plan.rs,kernel/src/expression_trie.rs,kernel/src/pattern_relations.rs,kernel/src/test_exprs.rs, andkernel/src/test_sidecar_queries.rsgit diff --checkgit diff -w --stat