Add BindingSpace signed delta join law - #91
Closed
MesTTo wants to merge 26 commits into
Closed
Conversation
Contributor
Author
|
Closing: signed-delta incremental view maintenance is deprioritized (not sink/source-compatible and expressible directly in MM2), and this lives in the un-wired binding_space island. Parking it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack dependency: review after #90. This branch is based on the trie-trace stack head, so GitHub may include prerequisite commits until that stack merges. The intended review increment is commit
8a754e7.Adds a signed delta-join operation for
BindingRelationand checks it against full recomputation with both insertions and deletions.The implementation follows the differential join identity while preserving MORK's signed row weights. The regression verifies that applying relation deltas produces the same result as rebuilding and joining the updated inputs.
Validation:
RUSTFLAGS='-C target-cpu=native' cargo +nightly-2026-06-01 test -p mork --lib binding_spaceRUSTFLAGS='-C target-cpu=native' cargo +nightly-2026-06-01 test -p mork --lib(54 passed)jscpd --reporters ai --format rust kernel/src/binding_space.rsgit diff --checkrustfmt --checkreports an existing formatting difference in an unchanged trace test inherited from the prerequisite branch. This PR does not reformat that unrelated code.