Add DNF diagnostics and existence queries - #96
Closed
MesTTo wants to merge 4 commits into
Closed
Conversation
Closed
Contributor
Author
|
Folded into #95: the DNF line was one unit split as serialized rewrites of the same function bodies (each PR restructured the previous one's code), so it is now a single coherent feature-gated PR — the reference evaluator with instrumentation, differentially sealed against PathMap's fused zipper_merge_dnf, with the empty-clause convention divergence pinned. See #95. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack dependency: review after #95.
Adds diagnostic counters to the semantic PathMap DNF evaluator and an existence-only query that stops after the first non-empty clause instead of materializing the final union.
The tests cover factor reuse, clause/intermediate sizes, duplicate output accounting, and existence short-circuiting. A small test helper removes duplicated overlap-stat assertions without changing production behavior.
Validation:
RUSTFLAGS='-C target-cpu=native -Awarnings' cargo +nightly-2026-06-01 test -p mork --lib --features experimental_dnf path_dnf(5 passed)RUSTFLAGS='-C target-cpu=native -Awarnings' cargo +nightly-2026-06-01 test -p mork --lib --features experimental_dnfrustfmt +nightly-2026-06-01 --edition 2024 --check kernel/src/path_dnf.rsjscpd --reporters ai --format rust kernel/src/path_dnf.rs(0 clones)git diff --check