Specify folders only in test/train JSON configs - #22
Open
NullLabTests wants to merge 1 commit into
Open
Conversation
All folder paths (generalization_set_folder, train_json, test_json) are now specified only in example_config.json and read via ConfigPaths at runtime. Changes: - Add generalization_set_folder, train_json, test_json to example_config.json for both block_type_classification and class_distribution_using_segmentation - Add corresponding fields to ConfigPaths and construct_configs() in both suites - Remove train_json, test_json, generalization_set_folder params from benchmark() function signatures; values are now read from ConfigPaths - Remove hardcoded generalization_set_folder from all 9 test_*_example.py scripts - dataset_index_creation_example.py now loads directory from example_config.json - images_to_distribution.py now loads basepath from example_config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all folder path specifications (generalization_set_folder, train_json, test_json) exclusively into
example_config.jsonfiles, removing them from Python function signatures and hardcoded script values.Changes
generalization_set_folder,train_json,test_jsonto bothexample_config.jsonfilesConfigPathsandconstruct_configs()in both benchmark suitestrain_json,test_json,generalization_set_folderparameters frombenchmark()function signaturesgeneralization_set_folderfrom all 9test_*_example.pyscriptsdataset_index_creation_example.pynow reads directory from configimages_to_distribution.pynow reads basepath from configFiles changed: 17 files