[codex] simplify skills repo structure - #48
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d4dec33. Configure here.
| target="$skill_dir/$rel_path" | ||
| mkdir -p "$(dirname "$target")" | ||
| rm -f "$target" | ||
| ln -s "../../_shared/$rel_path" "$target" |
There was a problem hiding this comment.
Hardcoded symlink depth breaks for nested shared files
Low Severity
The symlink target ../../_shared/$rel_path assumes every shared file is exactly one directory deep (e.g. scripts/foo.sh). If a file is added at _shared/references/subdir/file.md, the link at skills/<skill>/references/subdir/file.md would resolve ../../ to skills/<skill>/ instead of skills/, producing a broken symlink. Consider computing the relative path dynamically from $(dirname "$target") to the canonical file.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d4dec33. Configure here.


Summary
skills/_shared/, with per-skill local paths backed by symlinksValidation
shellcheck scripts/*.sh skills/_shared/scripts/tfy-api.sh && find skills -mindepth 2 -name '*.sh' -print0 | xargs -0 -r shellcheck./scripts/validate-skills.sh./scripts/validate-skill-security.sh./scripts/test-tfy-api.shgit diff --checkNote
Medium Risk
Medium risk because it restructures distribution/installation by removing plugin/hook infrastructure and changing install/sync/validation logic to rely on symlinks, which could break installs or CI on some environments.
Overview
Simplifies the repo to a skills-only package by removing editor/plugin manifests (
.claude-plugin/,.codex-plugin/,.cursor-plugin/), Cursor rules, top-levelagents/,commands/,hooks/,plugin-scripts/, and the PR template.Centralizes shared scripts/references under
skills/_shared/and replaces per-skill duplicated files with symlinks;scripts/sync-shared.shandscripts/validate-skills.shnow create and verify these links.Updates installation + CI/docs:
scripts/install.shnow installs_sharedonce and symlinks skills to it (copying only skill-specific extras), CI shellcheck scope is adjusted and adds an install help smoke test plus an e2e install matrix, and docs/templates are rewritten to reflect the new layout and reporting info.Reviewed by Cursor Bugbot for commit d4dec33. Bugbot is set up for automated code reviews on this repo. Configure here.