Skip to content

[codex] simplify skills repo structure - #48

Merged
mnvsk97 merged 1 commit into
mainfrom
codex/simplify-skills-repo
May 20, 2026
Merged

[codex] simplify skills repo structure#48
mnvsk97 merged 1 commit into
mainfrom
codex/simplify-skills-repo

Conversation

@mnvsk97

@mnvsk97 mnvsk97 commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • simplify the repo to a skills-only package by removing plugin manifests, plugin scripts, runtime hooks, top-level agent definitions, slash commands, and Cursor rules
  • centralize shared references and helper scripts under skills/_shared/, with per-skill local paths backed by symlinks
  • update installer, shared-link sync, validation, docs, issue templates, and CI for the simplified structure

Validation

  • shellcheck scripts/*.sh skills/_shared/scripts/tfy-api.sh && find skills -mindepth 2 -name '*.sh' -print0 | xargs -0 -r shellcheck
  • ./scripts/validate-skills.sh
  • ./scripts/validate-skill-security.sh
  • ./scripts/test-tfy-api.sh
  • temp install smoke across supported agent target directories
  • Markdown relative-link check
  • git diff --check

Note

Medium Risk
Medium risk because it restructures distribution/installation by removing plugin/hook infrastructure and changing install/sync/validation logic to rely on symlinks, which could break installs or CI on some environments.

Overview
Simplifies the repo to a skills-only package by removing editor/plugin manifests (.claude-plugin/, .codex-plugin/, .cursor-plugin/), Cursor rules, top-level agents/, commands/, hooks/, plugin-scripts/, and the PR template.

Centralizes shared scripts/references under skills/_shared/ and replaces per-skill duplicated files with symlinks; scripts/sync-shared.sh and scripts/validate-skills.sh now create and verify these links.

Updates installation + CI/docs: scripts/install.sh now installs _shared once and symlinks skills to it (copying only skill-specific extras), CI shellcheck scope is adjusted and adds an install help smoke test plus an e2e install matrix, and docs/templates are rewritten to reflect the new layout and reporting info.

Reviewed by Cursor Bugbot for commit d4dec33. Bugbot is set up for automated code reviews on this repo. Configure here.

@mnvsk97
mnvsk97 marked this pull request as ready for review May 20, 2026 15:47
@mnvsk97
mnvsk97 enabled auto-merge (squash) May 20, 2026 15:48
@mnvsk97
mnvsk97 merged commit 28bd072 into main May 20, 2026
17 checks passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4dec33. Configure here.

Comment thread scripts/sync-shared.sh
target="$skill_dir/$rel_path"
mkdir -p "$(dirname "$target")"
rm -f "$target"
ln -s "../../_shared/$rel_path" "$target"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded symlink depth breaks for nested shared files

Low Severity

The symlink target ../../_shared/$rel_path assumes every shared file is exactly one directory deep (e.g. scripts/foo.sh). If a file is added at _shared/references/subdir/file.md, the link at skills/<skill>/references/subdir/file.md would resolve ../../ to skills/<skill>/ instead of skills/, producing a broken symlink. Consider computing the relative path dynamically from $(dirname "$target") to the canonical file.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d4dec33. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants