Skip to content

chore: create and join agent wallets through sdk-go#124

Merged
MicBun merged 1 commit into
mainfrom
chore/maa-rule-flat-fee-numeric
Jun 22, 2026
Merged

chore: create and join agent wallets through sdk-go#124
MicBun merged 1 commit into
mainfrom
chore/maa-rule-flat-fee-numeric

Conversation

@MicBun

@MicBun MicBun commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

resolves: https://github.com/truflation/website/issues/4165

What

Routes agent-wallet rule creation and joining through the Go SDK instead of reimplementing the submission in the Python binding, so there is a single source of truth — matching how execute_agent_action already delegates to sdk-go's ExecuteAgentAction.

  • MAACreateRule / MAAJoin bindings now call sdk-go's CreateAgentRule / JoinAgentAddress and return the tx hash plus the rule_id / maa_address that sdk-go derives.
  • client.py uses those returned values instead of re-deriving locally; the standalone derivation helpers in utils.py are unchanged and still exported.
  • Re-pins sdk-go to pick up the rule flat-fee encoding (the fee now reaches the node as NUMERIC(78,0)), so no fee conversion is duplicated in the Python layer.

Notes

@holdex

holdex Bot commented Jun 22, 2026

Copy link
Copy Markdown

Time Submission Status

Member # Time Running Total Status Last Update
MicBun 3h ✅ Submitted Jun 22, 2026, 12:02 PM

Submit or update total time with:

@holdex pr submit-time 2h

Add time on top of previous submission with:

@holdex pr add-time 1h30m

See available commands to help comply with our Guidelines.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@MicBun, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 7 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc9f11b2-56f8-44e4-a6d3-2eedf74a2fc7

📥 Commits

Reviewing files that changed from the base of the PR and between fbef9ad and b78616b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • bindings/maa.go
  • go.mod
  • src/trufnetwork_sdk_py/client.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/maa-rule-flat-fee-numeric

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MicBun
MicBun force-pushed the chore/maa-rule-flat-fee-numeric branch from 99446ab to 67c5905 Compare June 22, 2026 11:51
@MicBun MicBun changed the title chore: send agent-wallet rule flat fees as on-chain decimals chore: create and join agent wallets through sdk-go Jun 22, 2026
@MicBun MicBun self-assigned this Jun 22, 2026
@MicBun

MicBun commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@holdex pr submit-time 3h

@MicBun
MicBun force-pushed the chore/maa-rule-flat-fee-numeric branch from 67c5905 to b78616b Compare June 22, 2026 12:04
@MicBun
MicBun merged commit 124a440 into main Jun 22, 2026
6 checks passed
@MicBun
MicBun deleted the chore/maa-rule-flat-fee-numeric branch June 22, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant