Fix Byte type None causing buffer error#94
Open
54M44R wants to merge 1 commit into
Open
Conversation
It is possible for a Byte enum to be None while also being valid
Owner
|
Both named bytes (enums) and raw bytes are valid. In most cases the variant can be determined from the serialized size, however bytes inside of maps are the exception. Would need external information to inform the parser on how to handle these cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not know much about the UE GVAS format, but it seems its possible for a Byte
enum_typeto beNonewhile also being a valid label for a Map?The structure is a Byte inside of a Map being used as the
key_typeMinimum reproducible save file that causes this issue (has been zipped due GitHub not supporting .sav):
min_save_file.zip
I tested the .sav by doing a roundtrip and can confirm that the save file is parsed properly to and from json. Not sure if this negatively impacts any other UE saves