2026-07-07 audit corrections: ADK bash-tool rename, AG2/OAI match guards, timeout harmonization, CSDK-121..124, CSKILL-001 recalibration#33
Merged
Conversation
… AG2/OAI guards, timeout callee harmonization, CSDK-121..124, hygiene de-gating)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections from the 2026-07-07 full rules audit (verified against live SDK sources) plus one calibration driven by maintainer feedback from the outreach program.
Rule fixes
ExecuteBashTool(the current google-adk class; upstream ships noBashToolclass) alongside the legacy name — these rules could not fire on current ADK code. ADK-008 explanation now also acknowledges the tool's built-in confirmation prompt.url_context/load_web_pageinstance forms (LoadWebPageis a function upstream, not a class).has_params: trueguard — no longer fires on zero-param tools.code_execution_config=False, the explicit-disable form their own fix text recommends.needs_approvalabsent or explicitlyFalse; a per-call approval callable (the SDK's documented HITL form) now counts as a gate and stays silent.mcp_servers=[].Sessionaliases, httpx, urllib both forms, aliased aiohttp); corrected CSDK-003's wrong NOTE about aiohttp alias canonicalization.New rules
claude_agent_definition): Bash / WebSearch / write built-ins / WebFetch grants on a TSAgentDefinition— previously a zero-coverage gap (CSDK-101..105 are python-gated).Hygiene
language: pythongate so TS-only repos get the agent-guidance-doc check.Merge order
Merge this before (or together with) the engine branch
cf/sharp-curie-ae4b0a— the engine fixture mirrors this content and its rules-sync CI job compares against this repo's main. The rulebook PR (trustabl-rulebook#fix/rules-audit-2026-07-07) carries the paired rationale docs and should land alongside.Engine-side: all fire/silent cases updated,
go test ./...green,check-rules-sync.shgreen against this branch, rulebookcheck_rulebook.pygreen.🤖 Generated with Claude Code