Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Removed redundant
set_perm_recursivecalls on subdirectories ofsystem/vendor/libandsystem/vendor/lib64(specifically theeglandhwsubdirectories) inMagisk Template/customize.sh.🎯 Why:
The parent directories (
system/vendor/libandsystem/vendor/lib64) are already recursively processed with the exact same SELinux context (u:object_r:same_process_hal_file:s0) and permissions just lines above. The recursive nature of those calls means that theeglandhwsubdirectories are implicitly handled, so repeating the process is unnecessary and wastes I/O and execution time.📊 Measured Improvement:
Running
tests/benchmark_permissions.shwith a large mocked directory structure:This represents a tangible execution time decrease in the permissions setting step, dropping O(N) redundant filesystem operations. Tests still fully pass (
tests/verify.sh).PR created automatically by Jules for task 12963022482045836368 started by @tryigit