Open
Conversation
- Couldn't get the code to compile, had to add #ifdef around "SDL_HINT_WINDOWS_DPI_AWARENESS" in Src/OSD/SDL/Main.cpp - Added a new "APP_IMAGE" flag to "Makefiles/Options.inc" - If flage is set, new options get set to "PLATFORM_LDFLAGS"
- Added the generated and downloaded files to the .gitignore so they won't accidentally get added - `AppImage/build_app_image.sh`: Bash script that automates the process of building out the app-image. Much easier to script it than have instructions - `AppImage/Supermodel.png`: Couldn't find an *official* Supermodel logo. Found a Sega Model 3 logo and resized it to AppImage specifications - Should be replaced with a *real* Supermodel logo in the future - `AppImage/Supermodel.desktop`: File required by the app-image - `AppImage/AppRun`: Bash script that is actually run by the app-image NOTE: I may be copying way too many libraries over (or I may also be missing some) to the app-image. I don't know what libraries should be available system-wide and which ones should be packaged in.
dafrenchyman
force-pushed
the
appimage
branch
8 times, most recently
from
a391ab9 to
044cee1
Compare
dafrenchyman
commented
Jan 12, 2025
| } | ||
|
|
||
| // Flag as DPI-aware, otherwise the window content might be scaled by some graphics drivers | ||
| #ifdef SDL_HINT_WINDOWS_DPI_AWARENESS |
Author
There was a problem hiding this comment.
I had to add this or it wouldn't compile on linux
- Ran into some issues with running the appimage directly via github. - Runs correctly if it's contents are extracted and ran that way instead - Did some changes to the AppRun that seems to make it find the libraries better
dafrenchyman
force-pushed
the
appimage
branch
from
044cee1 to
ca65a10
Compare
Author
|
Anyone around? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Summary:
PR to create an appimage along with a Github action that generates a latest release with the
x86_64based image attached. You can see it's successful creation here: https://github.com/dafrenchyman/Supermodel/releases/tag/latestNOTE:
Commit Notes:
1.) Preparing for AppImage creation
#ifdefaround "SDL_HINT_WINDOWS_DPI_AWARENESS" in Src/OSD/SDL/Main.cppAPP_IMAGEflag toMakefiles/Options.incPLATFORM_LDFLAGS2.) AppImage addition
AppImage/build_app_image.sh: Bash script that automates the process of building out the app-image. Much easier to script it than have instructionsAppImage/Supermodel.png: Couldn't find an official Supermodel logo. Found a Sega Model 3 logo and resized it to AppImage specificationsAppImage/Supermodel.desktop: File required by the app-imageAppImage/AppRun: Bash script that is actually run by the app-image3.) Github action to build the app-image