Implement SVG Board Textures (#534)#748
Open
notthecloudy wants to merge 2 commits intotscircuit:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| reject(new Error("Failed to load PNG image")) | ||
| } | ||
|
|
||
| img.src = URL.createObjectURL(blob) |
Contributor
There was a problem hiding this comment.
Memory leak: Object URLs created with URL.createObjectURL() are never revoked, causing memory to accumulate over time. Each texture generation creates a new blob URL that remains in memory until the page is closed.
Fix: Revoke the URL after the image loads:
img.onload = () => {
URL.revokeObjectURL(img.src);
ctx.drawImage(img, 0, 0);
const imageData = ctx.getImageData(0, 0, width, height);
// ... rest of the code
};
img.onerror = () => {
URL.revokeObjectURL(img.src);
reject(new Error("Failed to load PNG image"));
};This leak will manifest in production when users regenerate textures multiple times (e.g., when toggling layers or updating the circuit), causing browser memory to grow unbounded.
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements issue #534 — SVG Board Textures for PCB meshes in the 3D viewer.
Summary
New Dependencies
New Files Created
Modified Files
How to Use
/claim #534