Add inner_symbol_name, inner_symbol_align, and inner_symbol_size to schematic_component#527
Closed
MustafaMulla29 wants to merge 1 commit intomainfrom
Closed
Add inner_symbol_name, inner_symbol_align, and inner_symbol_size to schematic_component#527MustafaMulla29 wants to merge 1 commit intomainfrom
MustafaMulla29 wants to merge 1 commit intomainfrom
Conversation
…chematic_component
seveibar
requested changes
Apr 6, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
i don't think this makes sense as part of a schematic component, this is related to a schematic box i think? I'm also thinking that the way this is implemented makes custom symbols a bit more difficult to use- something to consider.
Contributor
|
i could be wrong- but what are the alternatives? Without seeing alternatives it's too hard to make a decision. Normally a PR like this would include an exploration of all major alternatives! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.