Standardize USB-C connector schematic pin labels#2131
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
requested review from
imrishabh18 and
seveibar
and removed request for
seveibar
| { label: "SHELL2", aliases: ["MH2", "EH2", "MOUNT2"] }, | ||
| { label: "SHELL3", aliases: ["MH3", "EH3", "MOUNT3"] }, | ||
| { label: "SHELL4", aliases: ["MH4", "EH4", "MOUNT4"] }, | ||
| ] |
| * USB-C signal names). Applied as additional per-pin aliases in initPorts | ||
| * so they flow to source_port.port_hints and the schematic display. | ||
| */ | ||
| private _derivedStandardPinLabels: Record<string, string> | null = null |
There was a problem hiding this comment.
this is an oxymoron, you cannot be both derived and standard, it confuses the direction of information
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
do not confuse the direction of information. The standard pin labels are not derived.
|
The code needs to be reoriented to avoid the confusion- it is written as if we use the circuit json to get pin labels. The pin labels do not come from the circuit json, we match the circuit json to standard pin labels |
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Same comment as before. Why is getStandardPinLabels taking in circuit json- it doesnt make sense. You need to start over
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Why arent thr stmbols the same tho?
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Thr symbols need to be identical
|
You can fix in the next pr |
2 participants
@seveibar should the
SHELLhandling be removed?