Open
Conversation
Comment on lines
+90
to
+94
| if (parameters.ep) { | ||
| const epw = 0.55 // exposed pad width | ||
| const eph = 0.35 // exposed pad height | ||
| pads.push(rectpad(["thermalpad"], 0, 0, epw, eph)) | ||
| } |
Contributor
There was a problem hiding this comment.
Critical bug: The exposed pad configuration accepts either true or { x: string, y: string } per the schema (lines 21-23), but the implementation only handles the boolean case and uses hardcoded dimensions. When users pass custom dimensions via object notation, they are ignored.
Fix: Handle both cases:
if (parameters.ep) {
let epw: number
let eph: number
if (typeof parameters.ep === 'object') {
epw = length.parse(parameters.ep.x)
eph = length.parse(parameters.ep.y)
} else {
epw = 0.55 // default exposed pad width
eph = 0.35 // default exposed pad height
}
pads.push(rectpad(["thermalpad"], 0, 0, epw, eph))
}
Suggested change
| if (parameters.ep) { | |
| const epw = 0.55 // exposed pad width | |
| const eph = 0.35 // exposed pad height | |
| pads.push(rectpad(["thermalpad"], 0, 0, epw, eph)) | |
| } | |
| if (parameters.ep) { | |
| let epw | |
| let eph | |
| if (typeof parameters.ep === 'object') { | |
| epw = length.parse(parameters.ep.x) | |
| eph = length.parse(parameters.ep.y) | |
| } else { | |
| epw = 0.55 // default exposed pad width | |
| eph = 0.35 // default exposed pad height | |
| } | |
| pads.push(rectpad(["thermalpad"], 0, 0, epw, eph)) | |
| } | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement SPDIP-28 (Shrink DIP, 28-pin) footprint for tscircuit/footprinter.
This adds a new
spdip28footprint that uses the existingdipfunction with fixed parameters appropriate for SPDIP-28 packages:Usage
Bounty