Remove disableAutoFocus in favor of focusOnHover={false}#717
Open
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Open
Remove disableAutoFocus in favor of focusOnHover={false}#717victorjzq wants to merge 1 commit intotscircuit:mainfrom
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Conversation
Replace disableAutoFocus in favor of focusOnHover={false} — the prop
defaults to false so focus is not stolen from the page on hover, and
users can opt in to focus-on-hover behavior by passing focusOnHover={true}.
victorjzq
requested review from
Abse2001,
ShiboSoftwareDev and
seveibar
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #163
Summary
disableAutoFocuswithfocusOnHoverprop (default:false) inPCBViewer,CanvasElementsRenderer, andDimensionOverlayfocusOnHover={false}(default) prevents the viewer from stealing page focus on mouse enter — equivalent to the olddisableAutoFocusbehaviorfocusOnHover={true}opts into focus-on-hover for keyboard shortcut support without clicking firsthover-behavior.fixture.tsxstory demonstrating both modesfocusOnHoverandclickToInteractEnabledpropsTest plan
focusOnHover={true}enables keyboard shortcuts (e.g. zoom hotkeys) when hovering without clickingfocusOnHover={false}(default) preserves textarea input when PCBViewer is on the same pagehover-behavior.fixture.tsxstories render correctly in Storybook